[
https://issues.apache.org/jira/browse/AMQ-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell updated AMQ-5597:
--------------------------------
Attachment: AMQ-5597_v2.patch
Updated patch with a small tweak to set a 'not found' error condition on the
detach when the 'null source lookup' attach used during unsubscribe fails to
find a matching subscription. This also prevents the NPE seen in the old
client, without the client change mentioned above.
> AMQP: clean up durable subscription unsubscribe handling to simplify and
> resolve issues
> ---------------------------------------------------------------------------------------
>
> Key: AMQ-5597
> URL: https://issues.apache.org/jira/browse/AMQ-5597
> Project: ActiveMQ
> Issue Type: Sub-task
> Components: AMQP
> Affects Versions: 5.11.0, 5.11.1
> Reporter: Robbie Gemmell
> Fix For: 5.12.0
>
> Attachments: AMQ-5597.patch, AMQ-5597_v2.patch
>
>
> The current unsubscribe processing is identifying a 'null-source lookup'
> attach as indication to immediately unsubscribe a durable subscription,
> performing some trickery with capabilities. There are actually many other
> reasons reasons a client might do this type of attach, which might lead to
> prematurely ending a subscription. Fully closing (rather than a non-closing
> detach) the durable subscription link is to be the signal ending the
> subscription. The related code should be fixed to resolve this, and generally
> cleaned up to simplify things.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
