[ 
https://issues.apache.org/jira/browse/AMQ-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Tully resolved AMQ-5620.
-----------------------------
    Resolution: Fixed

avoid the deadlock by allowing journal access during appender close.
http://git-wip-us.apache.org/repos/asf/activemq/commit/260e28ec

> deadlock on shutdown - kahadb and local tx rollback
> ---------------------------------------------------
>
>                 Key: AMQ-5620
>                 URL: https://issues.apache.org/jira/browse/AMQ-5620
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.11.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>              Labels: deadlock, kahadb, shutdown
>             Fix For: 5.12.0
>
>
> Deadlock found in a potential test case:{code}Found one Java-level deadlock:
> =============================
> "ActiveMQ BrokerService[localhost] Task-1":
>   waiting to lock monitor 0x00007feeeb80d108 (object 0x00000007f67294c8, a 
> org.apache.activemq.store.kahadb.disk.journal.Journal),
>   which is held by "pool-2-thread-1"
> "pool-2-thread-1":
>   waiting to lock monitor 0x00007feee8a34428 (object 0x00000007f67091f8, a 
> java.lang.Object),
>   which is held by "ActiveMQ BrokerService[localhost] Task-1"
> Java stack information for the threads listed above:
> ===================================================
> "ActiveMQ BrokerService[localhost] Task-1":
>       at 
> org.apache.activemq.store.kahadb.disk.journal.Journal.getCurrentWriteFile(Journal.java:420)
>       - waiting to lock <0x00000007f67294c8> (a 
> org.apache.activemq.store.kahadb.disk.journal.Journal)
>       at 
> org.apache.activemq.store.kahadb.disk.journal.DataFileAppender.enqueue(DataFileAppender.java:209)
>       - locked <0x00000007f67091f8> (a java.lang.Object)
>       at 
> org.apache.activemq.store.kahadb.disk.journal.DataFileAppender.storeItem(DataFileAppender.java:148)
>       at 
> org.apache.activemq.store.kahadb.disk.journal.Journal.write(Journal.java:647)
>       at 
> org.apache.activemq.store.kahadb.MessageDatabase.store(MessageDatabase.java:977)
>       at 
> org.apache.activemq.store.kahadb.MessageDatabase.store(MessageDatabase.java:959)
>       at 
> org.apache.activemq.store.kahadb.KahaDBTransactionStore.rollback(KahaDBTransactionStore.java:313)
>       at 
> org.apache.activemq.transaction.LocalTransaction.rollback(LocalTransaction.java:94)
>       - locked <0x00000007f6729698> (a 
> org.apache.activemq.store.kahadb.KahaDBTransactionStore)
>       at 
> org.apache.activemq.broker.TransactionBroker.removeConnection(TransactionBroker.java:323)
>       at 
> org.apache.activemq.broker.MutableBrokerFilter.removeConnection(MutableBrokerFilter.java:137)
>       at 
> org.apache.activemq.broker.TransportConnection.processRemoveConnection(TransportConnection.java:862)
>       - locked <0x00000007f6729810> (a 
> org.apache.activemq.broker.jmx.ManagedTransportConnection)
>       at 
> org.apache.activemq.broker.TransportConnection.doStop(TransportConnection.java:1187)
>       at 
> org.apache.activemq.broker.TransportConnection$4.run(TransportConnection.java:1117)
>       at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>       at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>       at java.lang.Thread.run(Thread.java:745)
> "pool-2-thread-1":
>       at 
> org.apache.activemq.store.kahadb.disk.journal.DataFileAppender.close(DataFileAppender.java:257)
>       - waiting to lock <0x00000007f67091f8> (a java.lang.Object)
>       at 
> org.apache.activemq.store.kahadb.disk.journal.Journal.close(Journal.java:474)
>       - locked <0x00000007f67294c8> (a 
> org.apache.activemq.store.kahadb.disk.journal.Journal)
>       at 
> org.apache.activemq.store.kahadb.MessageDatabase.close(MessageDatabase.java:438)
>       at 
> org.apache.activemq.store.kahadb.MessageDatabase.unload(MessageDatabase.java:466)
>       at 
> org.apache.activemq.store.kahadb.MessageDatabase.doStop(MessageDatabase.java:268)
>       at 
> org.apache.activemq.store.kahadb.KahaDBStore.doStop(KahaDBStore.java:288)
>       at org.apache.activemq.util.ServiceSupport.stop(ServiceSupport.java:71)
>       at org.apache.activemq.util.ServiceStopper.stop(ServiceStopper.java:41)
>       at org.apache.activemq.broker.BrokerService.stop(BrokerService.java:792)
>       at 
> org.apache.activemq.store.kahadb.PriorityMessageRestartBrokerTest.stopRestartBroker(PriorityMessageRestartBrokerTest.java:525)
>       at 
> org.apache.activemq.store.kahadb.PriorityMessageRestartBrokerTest.access$200(PriorityMessageRestartBrokerTest.java:70)
>       at 
> org.apache.activemq.store.kahadb.PriorityMessageRestartBrokerTest$BrokerRestartTask.run(PriorityMessageRestartBrokerTest.java:513)
>       at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>       at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304)
>       at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
>       at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>       at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>       at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>       at java.lang.Thread.run(Thread.java:745)
> Found 1 deadlock.{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to