[ 
https://issues.apache.org/jira/browse/AMQ-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349166#comment-14349166
 ] 

Robbie Gemmell commented on AMQ-5560:
-------------------------------------

Changes look good except 1 small issue, the descriptor value for the filters is 
allowed to be numeric or symbolic so we need to check for both as clients 
can/do send either.

https://svn.apache.org/repos/asf/qpid/trunk/qpid/specs/apache-filters.xml#type-no-local-filter
https://svn.apache.org/repos/asf/qpid/trunk/qpid/specs/apache-filters.xml#type-selector-filter

> AMQP: use type descriptors to inspect AMQP filter types rather than the map 
> keys
> --------------------------------------------------------------------------------
>
>                 Key: AMQ-5560
>                 URL: https://issues.apache.org/jira/browse/AMQ-5560
>             Project: ActiveMQ
>          Issue Type: Sub-task
>          Components: AMQP
>    Affects Versions: 5.10.0, 5.10.1, 5.11.0
>            Reporter: Robbie Gemmell
>            Assignee: Timothy Bish
>             Fix For: 5.12.0
>
>
> The broker is currently looking up AMQP filters using named keys of the 
> filter map. This approach is fragile, since difference clients may name 
> equivalent filters differently, as the names are not intended to identify 
> particular types. The broker should instead inspect the descriptor values 
> when trying to identify the particular type of a filter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to