Please don’t use @author tags…. Highly discouraged at apache as it implies some level of “ownership” over the file. If I see @author tags in files I’m in, I tend to remove them.
Dan > On Mar 9, 2015, at 2:45 PM, Clebert Suconic <[email protected]> wrote: > > just an idea... > > > you could see a comment to ActiveMQConfiguration with an @author tag, > and explain what you did in the past? > > > > For things like this we are loving the Pull Request workflow we are > using on activemq6 repo. You criticize such commits before they enter > the source history through a lightweight workflow. > > On Mon, Mar 9, 2015 at 1:59 PM, Hadrian Zbarcea <[email protected]> wrote: >> -1. Please remove. Does not belong in the code repository. >> I agree that credit should be given, but imo this is not the way. >> >> Hadrian >> >> >> >> On 03/09/2015 01:52 PM, [email protected] wrote: >>> >>> Repository: activemq >>> Updated Branches: >>> refs/heads/master e25a6aa8a -> b9b566918 >>> >>> >>> Add MERIT.txt and give thanks to Mark Frazier for his contribution. >>> >>> >>> Project: http://git-wip-us.apache.org/repos/asf/activemq/repo >>> Commit: http://git-wip-us.apache.org/repos/asf/activemq/commit/b9b56691 >>> Tree: http://git-wip-us.apache.org/repos/asf/activemq/tree/b9b56691 >>> Diff: http://git-wip-us.apache.org/repos/asf/activemq/diff/b9b56691 >>> >>> Branch: refs/heads/master >>> Commit: b9b566918e4e0ce0c33e0a4f73aff7551b7d6c66 >>> Parents: e25a6aa >>> Author: artnaseef <[email protected]> >>> Authored: Mon Mar 9 10:50:59 2015 -0700 >>> Committer: artnaseef <[email protected]> >>> Committed: Mon Mar 9 10:51:51 2015 -0700 >>> >>> ---------------------------------------------------------------------- >>> MERIT.txt | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> ---------------------------------------------------------------------- >>> >>> >>> http://git-wip-us.apache.org/repos/asf/activemq/blob/b9b56691/MERIT.txt >>> ---------------------------------------------------------------------- >>> diff --git a/MERIT.txt b/MERIT.txt >>> new file mode 100644 >>> index 0000000..1cec26b >>> --- /dev/null >>> +++ b/MERIT.txt >>> @@ -0,0 +1,15 @@ >>> +OVERVIEW >>> +======== >>> + >>> +This file contains thanks to contributors. Not all contributions are >>> here, but >>> +this file acts as a place to give thanks to those whose contributions are >>> not >>> +otherwise reflected in source code commits. >>> + >>> + >>> +MERIT >>> +===== >>> + >>> +Commit: 3ef8f492a7cb9c056ac1883ccb069e9559fc6b22 >>> + Author: Mark Frazier >>> + Message: Thank you for the patch provided here: >>> + https://issues.apache.org/jira/browse/AMQ-5563 >>> >> > > > > -- > Clebert Suconic > http://community.jboss.org/people/[email protected] > http://clebertsuconic.blogspot.com -- Daniel Kulp [email protected] - http://dankulp.com/blog Talend Community Coder - http://coders.talend.com
