Github user artnaseef commented on the pull request:
https://github.com/apache/activemq-6/pull/193#issuecomment-85133033
I think this helps, but want to see more. The copyright check here is very
aggressive and assumes that anyone working with the sources will only ever be
working with files that contain a matching license.
We can do better here, I'm sure of it. Here are some ideas:
a. Only run the copyright check on release build, or
b. Only run the copyright check when the build user specifies a maven
profile specific to that check, or
c. Limit the copyright check to files that are distributed with the
original sources (i.e. only files from git)
It is important to make development for all users easy. Apache projects
release source code, not binaries (although binaries are allowed as a
convenience). This means we anticipate many users working with the source
code. This even raises the question of whether it's valid in the Apache
ecosystem to restrict files in the development tree to those with the Apache
license; the license itself states "You may add Your own copyright statement to
Your modifications". This check appears to conflict with that statement.
Let's find an approach that makes Apache releases meet the required
licensing without passing that restriction outside of Apache. For comparison,
the existing ActiveMQ release process uses a manual step to execute the
copyright check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
