GitHub user thiagokronig opened a pull request:
https://github.com/apache/activemq-artemis/pull/236
Enables Google's Error Prone and fixes some mistakes
Also, I can squash or drop any of the commits. Let me know how can I be
helpful.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thiagokronig/activemq-artemis errorprone
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/236.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #236
----
commit fe21024e0a643626b357629727a6fcb5232f8a95
Author: Thiago Kronig <[email protected]>
Date: 2015-05-05T17:23:40Z
Enable Google's Error Prone
Enabled by default to catch common Java mistakes as compile-time errors.
https://github.com/google/error-prone
commit dc6ed08bf9dfda540bde4d11ace5fbeea49387cc
Author: Thiago Kronig <[email protected]>
Date: 2015-05-05T17:30:03Z
Fixes URISchema setFactory(..)
commit 5cc9fad0d4b5cb3069b3fefbf88ce0d0e58a074e
Author: Thiago Kronig <[email protected]>
Date: 2015-05-05T18:15:09Z
Ignore DepAnn Error Prone ERROR as WARN
DepAnn fail as ERROR for generated sources that implement deprecated
methods,
but don't annotate with @Deprecated.
Also, see: http://errorprone.info/bugpattern/DepAnn
commit b30b8842d1401cf8c86225862673f88e78581c47
Author: Thiago Kronig <[email protected]>
Date: 2015-05-08T23:12:15Z
Explicit byte[].toString(..) in debug message
commit 523ad13e297301ed8679c38668532a334888a5b5
Author: Thiago Kronig <[email protected]>
Date: 2015-05-08T23:22:29Z
Document lock.wait(..) idiom in SourceReceiver Thread
commit 1512aa93e6e796a1c62e7daf42e8e2f92d164ebb
Author: Thiago Kronig <[email protected]>
Date: 2015-05-08T23:31:51Z
Fix JMSQueueConfiguration interface to use varargs instead of array[]
commit 6ff1ceb28eb914ac384281c46c943e378957dfe3
Author: Thiago Kronig <[email protected]>
Date: 2015-05-08T23:35:55Z
ActiveMQRAStreamMessage writeBytes(..) should trace array contents
commit ed86af97a230a0b15da62eec47bcaaf0e5b20c32
Author: Thiago Kronig <[email protected]>
Date: 2015-05-08T23:41:28Z
Remove ignored line in JoramTests
commit 77611e91269d67cfbe1fab8436edbc71f270ff00
Author: Thiago Kronig <[email protected]>
Date: 2015-05-08T23:53:11Z
Log Arrays.toString(nodes) at ClusterTestBase
commit 9ae61d4f060faf1214b3426552d4cc2f98970489
Author: Thiago Kronig <[email protected]>
Date: 2015-05-09T00:06:49Z
Fix integration-tests: Arrays.toString(..) and ignored AssertionError
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
