Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/132#issuecomment-134293839
  
    This fix will only work on tests.... 
    
    on a default server, the acceptor will be at 0.0.0.0, and you will be 
sending tcp://0.0.0.0:port to the client.
    
    
    It's also wrong to the fact that the same protocolManager will server 
multiple acceptors in case you have multiple ports configured. on that case you 
will be sending the BrokerInfo for a different port or IP.
    
    
    Do you have the IP the user used to connect anywhere on the connection? So, 
you would have to create a brokerInfo per request.. instead caching a single 
one...
    
    
    
    for that reason this fix is not valid!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to