Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/468#issuecomment-211422106
@bgutjahr Hi. The issue with unbounded thread pools is that it can
eventually exhaust the system threads. We have seen this happen and the whole
server grinds to a hault. We introduced a fixed pool size, to avoid this
scenario (though it is possible to exhaust system memory, since we essentially
have an unbounded job queue). It is possible to add a setting to timeout
threads, which would solve your issue with the fixed thread pool, creating and
storing lots of threads. We've also recently changed the default thread pool
size to something more reasonable.
https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadPoolExecutor.html#allowCoreThreadTimeOut(boolean)
Your changes around API and injecting pools sounds good. I'll comment in
the commit.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
