Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/488#issuecomment-214939137
I think we should merge this... Testsuite seems ok... I ran quite a few
tests on this... evaluated the code.. it all seems nice... the testsuite is
saving 30 min overall time after this PR. which is great.
although 2 minor things:
I - I think this deserves a JIRA, and a commit ID associated with this
JIRA.. it's a nice feature to be on the release notes:
II - The executor has a property called m_executor... which is the C++
style of variable names. I would just use java style... such as ..
.currentExecutor.. or whatever... although I don't have a strong objection on
it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
