Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/494#issuecomment-215417342
@mtaylor I haven't changed anything in that regard...
the if (isTrace) is something we have done since the ancient days... all I
did was to individualize the loggers:
if you called log.trace("a" + "b" + integerSomething");
the string will be concatenated.. sent down to log.trace to only be reject
in case it was not traced.
In some cases we do quite a lot of traces.. at a very down level.. so that
would definitely be relevant.
It is really costly... but as I said.. I didn't change anything.. we were
already checking if (isTrace) some way or the other here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
