Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/677#discussion_r72632899
  
    --- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/CoreMessagingProxy.java
 ---
    @@ -30,21 +33,20 @@
     
        private final String resourceName;
     
    -   private final ClientSession session;
    +   private final ServerLocator locator;
     
    -   private final ClientRequestor requestor;
    +   private ClientSessionFactory sessionFactory;
    --- End diff --
    
    If you are always opening / closing on each call, why not to make it part 
of the method.
    
    What was the reason to not reuse the session?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to