Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/690#discussion_r72843751
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java
 ---
    @@ -549,7 +569,8 @@ public int getEncodeSize() {
              BufferHelper.sizeOfNullableBoolean(autoDeleteJmsQueues) +
              BufferHelper.sizeOfNullableBoolean(autoCreateJmsTopics) +
              BufferHelper.sizeOfNullableBoolean(autoDeleteJmsTopics) +
    -         BufferHelper.sizeOfNullableInteger(managementBrowsePageSize);
    +         BufferHelper.sizeOfNullableInteger(managementBrowsePageSize) +
    +         BufferHelper.sizeOfNullableLong(maxSizeBytesRejectThreshold);
    --- End diff --
    
    I suspect this could break compatibility on the bindings journal? better to 
check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to