Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/712#discussion_r74240789
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/proton/ProtonTest.java
---
@@ -211,6 +213,25 @@ public void testBrokerContainerId() throws Exception {
}
@Test
+ public void testBrokerConnectionProperties() throws Exception {
+ if (protocol != 0 && protocol != 3) return; // Only run this test
for AMQP protocol
--- End diff --
Yes. It'd be better to use an AssumeTrue or similar. We do this in many
other areas of the test class, so perhaps we can update the to use the junit
assertions in a separate commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
