Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/718#discussion_r74695394
--- Diff:
integration/activemq-vertx-integration/src/main/java/org/apache/activemq/artemis/integration/vertx/ActiveMQVertxLogger.java
---
@@ -38,7 +38,7 @@
* so an INFO message would be 191000 to 191999
*/
@MessageLogger(projectCode = "AMQ")
-public interface ActiveMQVertxLogger extends BasicLogger {
+interface ActiveMQVertxLogger extends BasicLogger {
--- End diff --
If we create separate packages within the module, you won't be able to
reuse the package private Logger.
Just because something is not using it now outside of the packet it doesn't
mean it eventually couldn't happen IMO
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
