Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/726#discussion_r75872240
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/jgroups/JChannelManager.java
---
@@ -34,7 +34,7 @@
private static final Logger logger =
Logger.getLogger(JChannelManager.class);
- private Map<String, JChannelWrapper> channels;
--- End diff --
It is not needed anyways.
ChannelBroadcastEndpointFactory::singletonManager is already static.
Revert this please. If you want to make sure this is static, we could make
the whole JChannelManager singleton. But I'm not sure now if there is a reason
to not to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
