GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/771
ARTEMIS-714 Improve JDBC Store
add DataSource and SQLProvider.Factory properties to
DataStorageConfiguration to externalize the configuration of the communication
with the JDBC data store instead of relying on global class path to load the
SQL connection and hard-coded values for the SQL provider choice
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-714
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesnil/activemq-artemis
ARTEMIS-714_JDBC_store
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/771.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #771
----
commit c2113b018177c3806c7dbad1f5ca8d2a0d383469
Author: Jeff Mesnil <[email protected]>
Date: 2016-09-08T15:46:09Z
ARTEMIS-714 Improve JDBC Store
add DataSource property to DatabaseStorageConfiguration to be able to
communicate with the data store using this DataSource instance instead
of relying on the creation the SQL connnection using the JDBC connection
URL/driver class name tuple.
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-714
commit 84328f070b928d353ce81153c1b86a4f287db6cc
Author: Jeff Mesnil <[email protected]>
Date: 2016-09-09T14:47:03Z
ARTEMIS-714 Improve JDBC store
bindingsJournal and messageJournal are already started in the start()
method. Remove redundant calls that were creating unused JDBC
connections that are never closed.
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-714
commit 94dc242d5374e51a3ee854faaaa305df399ed9c3
Author: Jeff Mesnil <[email protected]>
Date: 2016-09-12T09:17:53Z
ARTEMIS-714 Improve JDBC store
add SQLProvider.Factory property to DatabaseStorageConfiguration to
externalize the choice of the SQLProvider instead of relying on
hard-coded choices. If the property is null, the current behaviour will
be used (determing the SQLProvider based on the driver class name)
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-714
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
