Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/779#discussion_r79185878
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -2396,6 +2400,26 @@ public long getUptimeMillis() {
return new Date().getTime() - startDate.getTime();
}
+ public boolean addClientConnection(String clientId, boolean unique) {
+ final AtomicInteger i = connectedClientIds.putIfAbsent(clientId, new
AtomicInteger(1));
+ if (i != null) {
+ if (unique && i.get() != 0) {
+ return false;
+ }
+ else {
+ i.incrementAndGet();
+ connectedClientIds.put(clientId, i);
--- End diff --
This is to avoid race condition with remove.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
