Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/798#discussion_r80397193
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
 ---
    @@ -1259,6 +1259,7 @@ public RoutingStatus send(final ServerMessage 
message, final boolean direct, boo
           return send(getCurrentTransaction(), message, direct, 
noAutoCreateQueue);
        }
     
    +   @Override
    --- End diff --
    
    There is a way to avoid these on compile time, using Error Prone. 
    
    I have tried that, and I even had the changes... but we have some code 
generated.. we would need to ignore the generated code, or to make it also have 
overrides.
    
    @scop  Can we talk through IRC tomorrow, or google chat?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to