Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/924#discussion_r92667568
  
    --- Diff: 
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/queue/UpdateQueue.java
 ---
    @@ -31,7 +31,7 @@
        String name;
     
        @Option(name = "--deleteOnNoConsumers", description = "whether to 
delete when it's last consumers disconnects)")
    -   Boolean deleteOnNoConsumers = null;
    +   String deleteOnNoConsumers = null;
    --- End diff --
    
    You need to be creative with these names to avoid the -noNo case or course. 
 
    
    
    It is the framework we have at the moment. 
    
    
    
    Whatever you do it needs consistency.  
    
    
    Talking about consistency the exceptions need to show help errors and these 
addresses are not working on that sense.  I will make some fixes next week.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to