Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/955#discussion_r95383350
  
    --- Diff: 
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
 ---
    @@ -429,6 +442,12 @@ public void offerProducerCredit(final String address,
                                        final int threshold,
                                        final Receiver receiver) {
           try {
    +         // TODO - Do something smart here with the paging bits to figure 
out the credit can be sent.
    --- End diff --
    
    I don't think there's anything to be done with paging. If this is an 
anonymous producer, there's nothing to be done with paging...
    
    Either this is the proper implementation, hence you would need to remove 
the TODO, or this is something else broken.
    
    I believe you should just remove the TODO here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to