Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1015
  
    @cshannon it looks good...
    
    just one minor thing.. I have been trying to keep the commit message 
understandable at the first line...
    
    
    something like:
    
    ```
    ARTEMIS-964 Moving XML Conversion to blablabla
    
    https://issues.apache.org/jira/browse/ARTEMIS-964
    more blablablablablal...
    ```
    
    
    We have that on the hacking guide...
    
    
    
    you are a committer, you could of course bypass the "rule" if you have a 
strong feeling for this format.. .but it's just that this is helpful when doing 
bisects and git logs... I have had to bisect before and reading stuff on the 
first line would be helpful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to