I applied your patch, made a test and this is the stack trace :
17:25:18,643 WARN [org.apache.activemq.artemis.journal] AMQ142028: Error replaying pending commands after compacting: java.lang.NullPointerException at org.apache.activemq.artemis.core.journal.impl.JournalCompactor$UpdateCompactCommand.execute(JournalCompactor.java:485) [artemis-journal-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT] at org.apache.activemq.artemis.core.journal.impl.JournalCompactor.replayPendingCommands(JournalCompactor.java:244) [artemis-journal-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT] at org.apache.activemq.artemis.core.journal.impl.JournalImpl.compact(JournalImpl.java:1503) [artemis-journal-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT] at org.apache.activemq.artemis.core.journal.impl.JournalImpl$14.run(JournalImpl.java:1992) [artemis-journal-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT] at org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101) [artemis-commons-1.6.0-SNAPSHOT.jar:1.6.0-SNAPSHOT] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [rt.jar:1.8.0_66] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [rt.jar:1.8.0_66] at java.lang.Thread.run(Thread.java:745) [rt.jar:1.8.0_66] Thanks. On 14 March 2017 at 13:52, Clebert Suconic <[email protected]> wrote: > FYI: https://github.com/clebertsuconic/activemq-artemis/commit/ > 655f6beb040068759bcff0b93e042ef50e6326ca > > On Tue, Mar 14, 2017 at 9:49 AM, Clebert Suconic > <[email protected]> wrote: > > Same deal as during your restart... an update without an append (add) > > during compactation... > > > > this case was ignored though... I'm changing master to add a stack > > trace in case it happens again (so we can know for sure where it > > happened).. but I don't foresee any issues beyond the warning. > > > > On Mon, Mar 13, 2017 at 5:20 PM, Mohamed Badri <[email protected]> > wrote: > >> It works, after building packages from 1.x branch ( 1.6.0-SNAPSHOT ) > >> I was able to recover the 50K missing messages. > >> > >> Thanks a lot for that. > >> > >> On the same instance I had an NPE without stack trace. > >> Can someone explain me what happens, or what can be the cause > >> of the following messages logs : > >> > >> > >> *05:31:08,129 WARN [org.apache.activemq.artemis.journal] AMQ142007: > Can > >> not find record 59,006,361 during compact replay* > >> > >> *05:31:08,129 WARN [org.apache.activemq.artemis.journal] AMQ142007: > Can > >> not find record 59,006,351 during compact replay* > >> > >> *05:31:08,129 WARN [org.apache.activemq.artemis.journal] AMQ142007: > Can > >> not find record 59,006,377 during compact replay* > >> > >> *05:31:08,130 WARN [org.apache.activemq.artemis.journal] AMQ142007: > Can > >> not find record 59,006,353 during compact replay* > >> > >> *05:31:08,130 WARN [org.apache.activemq.artemis.journal] AMQ142007: > Can > >> not find record 59,006,379 during compact replay* > >> > >> *05:31:08,130 WARN [org.apache.activemq.artemis.journal] AMQ142012: > >> Couldnt find tx={0} to merge after compacting* > >> > >> *05:31:08,130 WARN [org.apache.activemq.artemis.journal] AMQ142012: > >> Couldnt find tx={0} to merge after compacting* > >> > >> *05:59:58,796 WARN [org.apache.activemq.artemis.journal] AMQ142028: > Error > >> replaying pending commands after compacting: java.lang. > NullPointerException* > >> > >> *05:59:58,798 WARN [org.apache.activemq.artemis.journal] AMQ142028: > Error > >> replaying pending commands after compacting: java.lang. > NullPointerException* > >> > >> > >> Thanks in advance. > >> > >> On 13 March 2017 at 15:35, Justin Bertram <[email protected]> wrote: > >> > >>> Should be merged now on master and 1.x branches. > >>> > >>> > >>> Justin > >>> > >>> ----- Original Message ----- > >>> From: "Clebert Suconic" <[email protected]> > >>> To: [email protected] > >>> Sent: Monday, March 13, 2017 10:25:40 AM > >>> Subject: Re: Artemis 1.5.2 - AMQ224000: Failure in initialisation: > >>> java.lang.NullPointerException > >>> > >>> It hasn't been merged yet... give me some time. > >>> > >>> On Mon, Mar 13, 2017 at 11:02 AM, Mohamed Badri <[email protected]> > >>> wrote: > >>> > Thanks a lot, > >>> > I'll apply this patch on the 1.5.4 release. > >>> > > >>> > > >>> > > >>> > On 13 March 2017 at 13:09, Clebert Suconic < > [email protected]> > >>> > wrote: > >>> > > >>> >> You will have to patch the server to be able to restart that server: > >>> >> > >>> >> https://github.com/apache/activemq-artemis/pull/1089 > >>> >> > >>> >> > >>> >> > >>> >> > >>> >> On Mon, Mar 13, 2017 at 5:42 AM, Mohamed Badri <[email protected]> > >>> wrote: > >>> >> > Hi, > >>> >> > > >>> >> > I'm using Artemis 1.5.2 > >>> >> > and after a problem due to load on the artemis server > >>> >> > I had to restart one instance. > >>> >> > > >>> >> > Then, when the instance with the following errors : > >>> >> > > >>> >> > ======================================================= > >>> >> > > >>> >> > 07:35:12,021 WARN [org.apache.activemq.artemis.journal] > AMQ142015: > >>> >> > Uncommitted transaction with id 702,425,640 found and discarded > >>> >> > > >>> >> > 07:35:12,021 WARN [org.apache.activemq.artemis.journal] > AMQ142015: > >>> >> > Uncommitted transaction with id 702,425,688 found and discarded > >>> >> > > >>> >> > 07:35:12,021 WARN [org.apache.activemq.artemis.journal] > AMQ142015: > >>> >> > Uncommitted transaction with id 702,425,713 found and discarded > >>> >> > > >>> >> > 07:35:12,021 WARN [org.apache.activemq.artemis.journal] > AMQ142015: > >>> >> > Uncommitted transaction with id 787,568,230 found and discarded > >>> >> > > >>> >> > 07:35:12,022 WARN [org.apache.activemq.artemis.journal] > AMQ142015: > >>> >> > Uncommitted transaction with id 787,568,362 found and discarded > >>> >> > > >>> >> > 07:35:12,022 WARN [org.apache.activemq.artemis.journal] > AMQ142015: > >>> >> > Uncommitted transaction with id 787,568,543 found and discarded > >>> >> > > >>> >> > 07:35:12,311 ERROR [org.apache.activemq.artemis.core.server] > >>> AMQ224000: > >>> >> > Failure in initialisation: java.lang.NullPointerException > >>> >> > > >>> >> > at > >>> >> > org.apache.activemq.artemis.core.persistence.impl.journal. > >>> >> AbstractJournalStorageManager.loadMessageJournal( > >>> >> AbstractJournalStorageManager.java:969) > >>> >> > [artemis-server-1.5.2.jar:1.5.2] > >>> >> > > >>> >> > at > >>> >> > org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl. > >>> >> loadJournals(ActiveMQServerImpl.java:2213) > >>> >> > [artemis-server-1.5.2.jar:1.5.2] > >>> >> > > >>> >> > at > >>> >> > org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl. > >>> >> initialisePart2(ActiveMQServerImpl.java:2067) > >>> >> > [artemis-server-1.5.2.jar:1.5.2] > >>> >> > > >>> >> > at > >>> >> > org.apache.activemq.artemis.core.server.impl. > >>> >> SharedNothingLiveActivation.run(SharedNothingLiveActivation. > java:104) > >>> >> > [artemis-server-1.5.2.jar:1.5.2] > >>> >> > > >>> >> > at > >>> >> > org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl. > >>> >> internalStart(ActiveMQServerImpl.java:520) > >>> >> > [artemis-server-1.5.2.jar:1.5.2] > >>> >> > > >>> >> > at > >>> >> > org.apache.activemq.artemis.core.server.impl. > >>> ActiveMQServerImpl.start( > >>> >> ActiveMQServerImpl.java:469) > >>> >> > [artemis-server-1.5.2.jar:1.5.2] > >>> >> > > >>> >> > at > >>> >> > org.apache.activemq.artemis.jms.server.impl. > >>> JMSServerManagerImpl.start( > >>> >> JMSServerManagerImpl.java:412) > >>> >> > [artemis-jms-server-1.5.2.jar:1.5.2] > >>> >> > > >>> >> > at > >>> >> > org.apache.activemq.artemis.integration.FileBroker.start( > >>> >> FileBroker.java:66) > >>> >> > [artemis-cli-1.5.2.jar:1.5.2] > >>> >> > > >>> >> > at > >>> >> > org.apache.activemq.artemis.cli.commands.Run.execute(Run.java:78) > >>> >> > [artemis-cli-1.5.2.jar:1.5.2] > >>> >> > > >>> >> > at > >>> >> > org.apache.activemq.artemis.cli.Artemis.internalExecute( > >>> >> Artemis.java:124) > >>> >> > [artemis-cli-1.5.2.jar:1.5.2] > >>> >> > > >>> >> > at org.apache.activemq.artemis. > cli.Artemis.execute(Artemis. > >>> >> java:81) > >>> >> > [artemis-cli-1.5.2.jar:1.5.2] > >>> >> > > >>> >> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > >>> Method) > >>> >> > [rt.jar:1.8.0_66] > >>> >> > > >>> >> > at > >>> >> > sun.reflect.NativeMethodAccessorImpl.invoke( > >>> >> NativeMethodAccessorImpl.java:62) > >>> >> > [rt.jar:1.8.0_66] > >>> >> > > >>> >> > at > >>> >> > sun.reflect.DelegatingMethodAccessorImpl.invoke( > >>> >> DelegatingMethodAccessorImpl.java:43) > >>> >> > [rt.jar:1.8.0_66] > >>> >> > > >>> >> > at java.lang.reflect.Method.invoke(Method.java:497) > >>> >> > [rt.jar:1.8.0_66] > >>> >> > > >>> >> > at > >>> >> > org.apache.activemq.artemis.boot.Artemis.execute(Artemis. > java:129) > >>> >> > [artemis-boot.jar:1.5.2] > >>> >> > > >>> >> > at org.apache.activemq.artemis.boot.Artemis.main(Artemis. > >>> >> java:49) > >>> >> > [artemis-boot.jar:1.5.2] > >>> >> > ======================================================= > >>> >> > > >>> >> > After that the instance stops and I can't recover the queues and > >>> messages > >>> >> > persisted before I stopped the instance. > >>> >> > > >>> >> > This instance is master in a replication setup, > >>> >> > when this problem happened the slave was stopped. > >>> >> > > >>> >> > Any Information on this problem ? > >>> >> > Thanks in advance. > >>> >> > >>> >> > >>> >> > >>> >> -- > >>> >> Clebert Suconic > >>> >> > >>> > >>> > >>> > >>> -- > >>> Clebert Suconic > >>> > > > > > > > > -- > > Clebert Suconic > > > > -- > Clebert Suconic >
