New Coverity Scan results are here. Before posting that, I decided to also
make a list of previously reported items that were fixed during the course
of the week.
The following six Coverity Scan items were fixed or somehow removed during
the last week. They are listed together with commit that removed them.
The interesting thing here could be the 'Revert "ARTEMIS-1093 Full
qualified queue name support"' commit, I think.
ARTEMIS-1089 Improving flow control on replication:
CID 1426233 (#1 of 1): Thread deadlock (LOCK_INVERSION)
9. lock_order: Acquiring lock PagingStoreImpl.lock while holding
ReplicationManager.replicationLock conflicts with the lock order
established elsewhere. [show details]
ARTEMIS-1096 Changing Global Max Size's default:
CID 1419093 (#1 of 1): RV: Bad use of return value
(FB.RV_RETURN_VALUE_IGNORED_BAD_PRACTICE)
1. defect: Exceptional return value of java.io.File.mkdirs() ignored.
(the code was only changed to form that either Coverity no longer
recognizes for purposes of the return-value-ignored warning, or the changes
caused Coverity to close this warning and create new one)
CID 1418686 (#1 of 1): DLS: Dead local store (FB.DLS_DEAD_LOCAL_STORE)
1. defect: Dead store to fileConfiguration.
ARTEMIS-1094 replica + group-name fix:
CID 1409075 (#1 of 1): Unguarded read (GUARDED_BY_VIOLATION)
1. missing_lock: Accessing liveConfiguration without holding lock
NamedLiveNodeLocatorForReplication.lock.lock(). Elsewhere,
"org.apache.activemq.artemis.core.server.impl.NamedLiveNodeLocatorForReplication.liveConfiguration"
is accessed with NamedLiveNodeLocatorForReplication.lock.lock() held 4 out
of 5 times.
Revert "ARTEMIS-1093 Full qualified queue name support"
CID 1428146 (#1 of 1): EC: Comparing incompatible types for equality
(FB.EC_UNRELATED_TYPES)
1. defect: Call to
String.equals(org.apache.activemq.artemis.api.core.SimpleString).
ARTEMIS-1108: Removed AIOFileLockManager:
CID 1418595 (#1 of 1): DLS: Dead local store (FB.DLS_DEAD_LOCAL_STORE)
1. defect: Dead store to file.
--
Jiří Daněk
