I will want the full test. Just to be safe. Something I do on my box. Just to be safe.
Will merge the afternoon. On Mon, Jun 5, 2017 at 11:13 AM michaelandrepearce <[email protected]> wrote: > Github user michaelandrepearce commented on a diff in the pull request: > > > https://github.com/apache/activemq-artemis/pull/1316#discussion_r120130864 > > --- Diff: > artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerSenderContext.java > --- > @@ -738,17 +738,14 @@ private static String createQueueName(String > clientId, > boolean shared, > boolean global, > boolean isVolatile) { > - String queue = clientId == null || clientId.isEmpty() ? pubId : > clientId + "." + pubId; > + String queue = clientId == null || clientId.isEmpty() || global > ? pubId : clientId + "." + pubId; > --- End diff -- > > And build is green :) > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > --- > -- Clebert Suconic
