Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1321
It is indeed validating the same property, that property is the
SOLE_CONTAINER capability that is sent in the open frame to indicate the
uniqueness of the client ID as being required.
What you are testing is the Qpid JMS client specific implementation of the
setClientID and how it controls when the open frame is sent. What you aren't
testing in the new test is the affect of not specifying a client ID and also
the behavior of setClientID through the Connection or no client ID being set
and calling connection start.
So if you feel you need this particular test case then for completeness I'd
argue you test all variations of client ID / no client ID and ConnectionFactory
vs Connection setClientID.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
