Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1328
Couple of things...
* The methods createQueueNameForLegacySubscription and
createQueueNameForAmqpCompatibleSubscription in
org.apache.activemq.artemis.jms.client.ActiveMQDestination are almost exactly
the same. I'd rather not have that kind of code duplication. You could just
replace the logic in createQueueNameForSubscription with the logic from
createQueueNameForLegacySubscription and refactor escape to take the
amqpCompatibleQueues boolean. That's just one way to do; there's lots of ways
to avoid the code duplication here.
* I know it's tempting to make unrelated but worthwhile changes in a PR
(e.g. removing the unused method decomposeQueueNameForDurableSubscription).
I've done it myself. However, it makes the diff harder to read and understand
since the change isn't clearly related.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
