Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1337
@gemmellr Thanks for the feedback on this one Robbie. I think my opinions
were reflected on the related PR by other members. This approach looks good to
me.
Re: Configuration, we may want to pull out protocol specific properties
into their own configuration objects (like we have with HA policies). e.g.
<protocols><amqp><...>. But that will require some refactor, which can come
later if people feel it's necessary. I think what @michaelandrepearce has done
here is fine.
I'll kick off a full test suite run before merging.
Cheers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
