Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1393#discussion_r126493130
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
---
@@ -338,7 +338,7 @@ public ClientSession createSession(final boolean xa,
return createSessionInternal(null, null, xa, autoCommitSends,
autoCommitAcks, preAcknowledge, serverLocator.getAckBatchSize());
}
- // ConnectionLifeCycleListener implementation
--------------------------------------------------
--- End diff --
where is the deprecation? I see this a fix, but I'm not sure why you're
calling this a deprecation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---