GitHub user dtrebbien opened a pull request:
https://github.com/apache/activemq/pull/257
Misc. fixes
While testing my [SLF4J Helper](http://plugins.netbeans.org/plugin/72557/)
plugin for NetBeans IDE, I found some fixes and minor improvements that can be
made.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dtrebbien/activemq misc-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq/pull/257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #257
----
commit 2897dd09d3109b05251617059b53f785d1dc9b9e
Author: Daniel Trebbien <[email protected]>
Date: 2017-07-29T01:43:41Z
Utilize parameterized logging and remove calls to toString()
As suggested in the SLF4J FAQ:
https://www.slf4j.org/faq.html#logging_performance
parameterized logging can improve the efficiency of logger calls when
logging at the specified level is disabled.
In addition, per the FAQ: https://www.slf4j.org/faq.html#paramException
since SLF4J 1.6.0 it is possible to use parameterized logging and also
log an exception/throwable.
toString() is called automatically:
https://www.slf4j.org/faq.html#string_contents
These changes were suggested by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
commit 9c11c24a0f270202812328be679262310c0166b4
Author: Daniel Trebbien <[email protected]>
Date: 2017-07-29T01:58:05Z
Fix some incorrect SLF4J logger calls
In some cases, there were an inconsistent number of formatting anchors.
In other cases, formatting anchors were used, but because the
trace/debug/info/warn/error(String, Throwable) variant was used, the
string is a message string rather than a format string.
These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
commit 5eca75a870b11b7d1cda2233231092c8a1dc5291
Author: Daniel Trebbien <[email protected]>
Date: 2017-07-29T02:18:26Z
Fix an apparent copy/paste typo
commit 4133cc3df872e9cf5732cd85ea7ef271b0876c73
Author: Daniel Trebbien <[email protected]>
Date: 2017-07-29T02:23:27Z
Fix some typos
commit 4b83641a2b55afa5c29e350480bb52bb09c70584
Author: Daniel Trebbien <[email protected]>
Date: 2017-07-29T02:24:59Z
Use simpler SLF4J API functions
Eliminates the need to construct a new (temporary) Object array object.
These changes were suggested by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
commit 1cc482568d4c21065880c0f4294ce6aecdb956f7
Author: Daniel Trebbien <[email protected]>
Date: 2017-07-29T02:28:18Z
Reformat some code
commit a582b84e0f159e667020b4a7975d66edc4173506
Author: Daniel Trebbien <[email protected]>
Date: 2017-07-29T02:29:42Z
Mark boolean 'debug' fields as transient
commit 62ee55a43ecfab05428579f78dd505a629bd6b95
Author: Daniel Trebbien <[email protected]>
Date: 2017-07-29T02:32:59Z
Mark `staticCache' final
This fixes a warning in NetBeans IDE about synchronizing on a non-final
field.
commit 4a337d380093f533dad621d388585841cffa0dc1
Author: Daniel Trebbien <[email protected]>
Date: 2017-07-29T02:47:35Z
Fix inconsistent 'info'-level logger calls
Some calls to info() were guarded by checks that logging at the trace
level is enabled.
These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
