Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1445#discussion_r131682621
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java
 ---
    @@ -537,7 +540,11 @@ public void connectionDestroyed(final Object 
connectionID) {
           if (conn != null && !conn.connection.isSupportReconnect()) {
              RemotingConnection removedConnection = 
removeConnection(connectionID);
              if (removedConnection != null) {
    -            server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> 
plugin.afterDestroyConnection(removedConnection) : null);
    +            try {
    +               server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin 
-> plugin.afterDestroyConnection(removedConnection) : null);
    +            } catch (Exception e) {
    +               throw new IllegalStateException("Error executing 
afterDestroyConnection plugin method: " + e.getMessage(), e);
    --- End diff --
    
    make it catch Throwable :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to