Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1468#discussion_r133722903
--- Diff:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java
---
@@ -304,7 +304,7 @@ public void run() {
try {
libaioFile.write(position, bytes, buffer, this);
} catch (IOException e) {
- callback.onError(-1, e.getMessage());
--- End diff --
hmmm.. nice catch...
I though other things would catch the failures..
The proper fix should been:
```
callback.onError(-1, errorMessage);
onIOError(e, "Failed to write to file", sequentialFile);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
