Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1501#discussion_r136555064
  
    --- Diff: 
artemis-hawtio/activemq-branding/src/main/webapp/plugin/js/plugin.js ---
    @@ -59,10 +59,14 @@ var activemqBranding = (function (self) {
     
         self.module = angular.module(self.pluginName, ['hawtioCore']);
         self.module.run(function (branding) {
    -        self.log.debug("ActivMQ theme loaded");
    +        self.log.info("ActiveMQ theme loaded");
    +        if (localStorage['theme'] != 'activemq' || 
localStorage['branding'] != 'activemq') {
    +            localStorage['theme'] = 'activemq';
    +            localStorage['branding'] = 'activemq';
    +            location.reload();
    --- End diff --
    
    If anything those existing if and set can be removed entirely. The set 
should be within the run from what I understood debugging. Because I couldn't 
recreate though I didn't want to remove in case of some other side effect. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to