Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1502#discussion_r136587682
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
 ---
    @@ -1599,7 +1599,7 @@ protected void confirmLargeMessage(final 
LargeServerMessage largeServerMessage)
                 
confirmPendingLargeMessage(largeServerMessage.getPendingRecordID());
                 
largeServerMessage.setPendingRecordID(LargeServerMessage.NO_PENDING_ID);
              } catch (Exception e) {
    -            ActiveMQServerLogger.LOGGER.warn(e.getMessage(), e);
    --- End diff --
    
    I would just log the warn here.. no need for a special ID!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to