I will retag based on the feedback.. thanks for catching these issues...
I still didn't reproduce the Logger issue though.. tried with many environments.. different settings.. and nothing so far. On Fri, Sep 1, 2017 at 8:37 AM, Clebert Suconic <[email protected]> wrote: > Consider it canceled. I will send a Cancel email when I get to a computer. > > > One thing I will need is the exact sequence of comands Tim used to get the > logger error. Or if that was environmental. I couldn't reproduce that on > in different envs. > > On Fri, Sep 1, 2017 at 4:22 AM Martyn Taylor <[email protected]> wrote: >> >> -1. >> >> I managed to reproduce this. In Firefox (which I rarely use), I loaded up >> the console to be only to be greeted by the HawtIO branding... sigh... >> After checking the localStorage settings from Michael's commit, I could >> see >> that they were set to: >> >> theme="default" >> branding="hawtio" >> >> A bit of digging shows that this is part of HawtIO proper: >> >> https://github.com/hawtio/hawtio/blob/master/hawtio-web/src/main/webapp/app/themes/js/themesPlugin.ts#L57-L58 >> >> If anyone has used any HawtIO plugin previously there's a potential this >> issue can surface for them. Clebert, we will need to fix and rebuild. >> >> Michael I tested your patch and it solves the problem. I have some >> comments, I will post on the PR. >> >> Thanks >> >> >> >> On Fri, Sep 1, 2017 at 8:47 AM, Martyn Taylor <[email protected]> wrote: >> >> > Tim, >> > >> > Are you sure your browser has not cached a previous version of the >> > HawtIO >> > branding? What happens if you run inside of private browse mode? >> > >> > On Fri, Sep 1, 2017 at 6:19 AM, Michael André Pearce < >> > [email protected]> wrote: >> > >> >> Hi Guys, >> >> >> >> Like Clebert I cannot reproduce. >> >> >> >> I have a hunch I think what's going on, and have made a PR to address >> >> that if it is the case. >> >> >> >> But I really need a reproducer to test it, Tim I'm hoping you can help >> >> us >> >> here? I have tagged you both in the PR. >> >> >> >> Cheers >> >> Mike >> >> >> >> Sent from my iPhone >> >> >> >> On 1 Sep 2017, at 02:05, Clebert Suconic <[email protected]> >> >> wrote: >> >> >> >> >> /Users/clebertsuconic/Downloads/apache-artemis-2.3.0 foo >> >> > worked on my mac, and two different linuxes I have access.. perhaps >> >> > it >> >> > was something else on your box? >> >> > >> >> > You must be doing something wrong there. >> >> > >> >> >> FireFox v55.0.2 on my Linux machine shows Hawt.io branding, the site >> >> does >> >> >> show the ActiveMQ branding in Chromium though but I'd suggest trying >> >> >> a >> >> range >> >> >> of browsers and platforms. >> >> > >> >> > I tried that and it worked... >> >> > You must be doing something wrong there :) >> >> > lets talk tomorrow over IRC. >> >> >> > >> > > > -- > Clebert Suconic -- Clebert Suconic
