Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1502#discussion_r137272049
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterManager.java
---
@@ -542,15 +542,15 @@ public void clear() {
try {
bridge.stop();
} catch (Exception e) {
- ActiveMQServerLogger.LOGGER.warn(e.getMessage(), e);
--- End diff --
On this case it's better logger.warn(e.getMessage(), e);
failedToStopBridge(e) wouldn't buy us much in terms of extra information.
ActiveMQServerLogger.LOGGER would somewhat hide where it's happening..
although you would have the stack trace... but I would prefer logger.warn...
I'm a bit concerned about poluting the Logger with too many log codes..
it's already complicated to manage it.
---
