Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1534#discussion_r139573407
  
    --- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpClientTestSupport.java
 ---
    @@ -185,6 +187,7 @@ protected TransportConfiguration 
addAcceptorConfiguration(ActiveMQServer server,
           HashMap<String, Object> params = new HashMap<>();
           params.put(TransportConstants.PORT_PROP_NAME, String.valueOf(port));
           params.put(TransportConstants.PROTOCOLS_PROP_NAME, 
getConfiguredProtocols());
    +      params.put(TransportConstants.NETTY_READ_TIMEOUT, readTimeout);
    --- End diff --
    
    3 ms seems very small even for test case, also test should test without 
setting this that error does occur. Eg assert the problem exists without 
setting.


---

Reply via email to