Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1559#discussion_r141695802
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalAnalyzerImpl.java
---
@@ -147,6 +147,7 @@ public void run() {
// this means that the server has been stopped as we
could acquire the semaphore... returning now
break;
}
+ logger.trace("Checking critical analyzer");
--- End diff --
Was this left in by mistake? I ask because it looks like it will be on the
critical path for any checks. Maybe surround it with if (traceEnabled)?
---
