Github user ryeats commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1561
  
    Essentially this is copying netty inside the artemis-server-osgi jar 
because UnpooledUnsafeDirectByteBufWrapper needs package private access to some 
classes in netty. The downside is the manifests in those jars are ignored and 
we have to make sure the one in artemis-service-osgi satisfies all of netty's 
imports now. i.e. if we update Netty versions and they added a new dependency 
we will have to add an exclusion to our Import-Package or install an additional 
bundle. Frankly we should probably not be doing something that requires package 
private access to Netty but I realize its doing some cool stuff.  As for a more 
elegant solution I am not sure if this is feasible but possibly contributing a 
low level api to Netty so we don't need package private access.


---

Reply via email to