Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1578
  
    @clebertsuconic Thanks, now I see it!
    Currently the MappedSequentialFileFactory doesn't extend the 
AbstractSequentialFileFactory, hence it can't work for the MAPPED journal...
    > Regarding MAPPED.. I didn't merge that one before because I thought we 
were lacking tests... I had a test on my workspace for Unbuffered.. but I think 
I missed it...
    
    Yes, I don't know how the callbacks behave using unbuffered version, but if 
it works for NIO for MAPPED it will work too..
    
    > I think we should change the CLI to make timeout = 0 if sync = false (for 
all the journals.. not just MAPPED). and add a text on the broker.xml saying we 
recommend disabling if sync=false.
    
    :100: 
    



---

Reply via email to