Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1576
  
    ```
          insertStateOnNodeManagerStoreTableSQL = "INSERT INTO " + tableName + 
" (ID) VALUES (0)";
          insertNodeIdOnNodeManagerStoreTableSQL = "INSERT INTO " + tableName + 
" (ID) VALUES (3)";
          insertLiveLockOnNodeManagerStoreTableSQL = "INSERT INTO " + tableName 
+ " (ID) VALUES (1)";
          insertBackupLockOnNodeManagerStoreTableSQL = "INSERT INTO " + 
tableName + " (ID) VALUES (2)";
    ```
    
    Wouldn't be better to have a single statement (Using a separate table as I 
had already asked).. using prepared statements?
    
    I'm a bit concerned also that the semantic of 1, 2 and 3.. is inside the 
literal string.. and I see no references on the LeaseLock implementation. I 
wouldn't understand how to debug this.. it makes it harder to maintain IMO.


---

Reply via email to