Github user ppatierno commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1592#discussion_r145434452
  
    --- Diff: 
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
 ---
    @@ -67,6 +76,8 @@
     
        public static final int DEFAULT_KEEP_ALIVE_FREQUENCY = 5000;
     
    +   public static final String logUTF8PublishPayload = 
System.getProperty("org.apache.activemq.artemis.core.protocol.mqtt.logUTF8PublishPayload");
    --- End diff --
    
    My 2 cents. The PUBLISH payload has a maximum size of 256 MB. I could have 
a use case where I need tracing packets but not printing 256 MB of bytes on the 
console. Use case where could be a problem in the messages flow that is not 
dependent on the payload. In this moment using just TRACE enabled or not it's 
just about having or not the logging. Maybe we could use DEBUG for normal 
packets logging and then TRACE for printing the payload as well.


---

Reply via email to