Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1534#discussion_r146324088
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/TransportConstants.java
---
@@ -255,6 +255,10 @@
public static final int DEFAULT_STOMP_MAX_FRAME_PAYLOAD_LENGTH = 65536;
+ public static final String NETTY_HANDSHAKE_TIMEOUT =
"protocol-header-timeout";
--- End diff --
Names here should be consistent to avoid confusion between the code/config.
Maybe something like:
HANDSHAKE_TIMEOUT = "handshake-timeout"
---
