Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1628#discussion_r151136266
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
 ---
    @@ -1387,4 +1387,49 @@ public boolean isBrowsed() {
              return b;
           }
        }
    +   
    +   @Override
    +   public long getSequentialID() {
    +       return sequentialID;
    +   }
    +
    +   @Override
    +   public SimpleString getQueueName() {
    +       return getQueue().getName();
    +   }
    +
    +   @Override
    +   public RoutingType getQueueType() {
    +       return getQueue().getRoutingType();
    +   }
    +
    +   @Override
    +   public SimpleString getQueueAddress() {
    +       return getQueue().getAddress();
    +   }
    +
    +   @Override
    +   public String getSessionName() {
    +       return server.getSessionByID(getSessionID()).getName();
    +   }
    +
    +   @Override
    +   public String getConnectionClientID() {
    +       return 
server.getSessionByID(getSessionID()).getRemotingConnection().getClientID();
    +   }
    --- End diff --
    
    Same comment as above and in all other places you are doing the lookup.


---

Reply via email to