Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1657#discussion_r151215473
  
    --- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/AdvisoryOpenWireTest.java
 ---
    @@ -0,0 +1,148 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.tests.integration.openwire;
    +
    +import org.apache.activemq.artemis.api.core.management.AddressControl;
    +import org.apache.activemq.artemis.api.core.management.QueueControl;
    +import org.apache.activemq.artemis.tests.util.Wait;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +import javax.jms.Connection;
    +import javax.jms.Session;
    +import javax.jms.TemporaryQueue;
    +import javax.jms.TemporaryTopic;
    +
    +public class AdvisoryOpenWireTest extends BasicOpenWireTest {
    +
    +   @Override
    +   @Before
    +   public void setUp() throws Exception {
    +      //this system property is used to construct the executor in
    +      
//org.apache.activemq.transport.AbstractInactivityMonitor.createExecutor()
    +      //and affects the pool's shutdown time. (default is 30 sec)
    +      //set it to 2 to make tests shutdown quicker.
    +      
System.setProperty("org.apache.activemq.transport.AbstractInactivityMonitor.keepAliveTime",
 "2");
    --- End diff --
    
    This kind of thing is a potential source of issues on another tests...
    
    Can you cleanup the property on a tearDown please?


---

Reply via email to