Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1659#discussion_r151612096
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
@@ -88,20 +83,6 @@
private boolean finalizeChecks;
- @Override
- public void writeExternal(ObjectOutput out) throws IOException {
- URI uri = toURI();
-
- try {
- out.writeUTF(uri.toASCIIString());
--- End diff --
No it is serialising fine, in fact this is what tomcat resources is doing,
this is exactly what we are purposely changing to fix the issue, it needs to
serialise into an array of StringRefAddr (properties).
---
