Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1665#discussion_r153621262
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
---
@@ -656,17 +672,15 @@ private void addResendPacket(Packet packet) {
resendCache.add(packet);
if (logger.isTraceEnabled()) {
- logger.trace("ChannelImpl::addResendPacket adding packet " +
packet + " stored commandID=" + firstStoredCommandID + " possible commandIDr="
+ (firstStoredCommandID + resendCache.size()));
+ logger.trace("RemotingConnectionID=" + (connection == null ?
"NULL" : connection.getID()) + " ChannelImpl::addResendPacket adding packet " +
packet + " stored commandID=" + firstStoredCommandID + " possible commandIDr="
+ (firstStoredCommandID + resendCache.size()));
}
}
private void clearUpTo(final int lastReceivedCommandID) {
final int numberToClear = 1 + lastReceivedCommandID -
firstStoredCommandID;
if (logger.isTraceEnabled()) {
- logger.trace("ChannelImpl::clearUpTo lastReceived commandID=" +
lastReceivedCommandID +
- " first commandID=" + firstStoredCommandID +
- " number to clear " + numberToClear);
+ logger.trace("RemotingConnectionID=" + (connection == null ?
"NULL" : connection.getID()) + " ChannelImpl::clearUpTo lastReceived
commandID=" + lastReceivedCommandID + " first commandID=" +
firstStoredCommandID + " number to clear " + numberToClear);
--- End diff --
@pgfox I have already merged.. not a big deal.. but if you could avoid long
lines on future PRs? :)
that might apply to myself as well :) so I will be more careful as well.
---
