Github user stanlyDoge commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1688#discussion_r155719121
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
 ---
    @@ -253,9 +253,12 @@ public Configuration parseMainConfig(final InputStream 
input) throws Exception {
           String xml = XMLUtil.readerToString(reader);
           xml = XMLUtil.replaceSystemProps(xml);
           Element e = XMLUtil.stringToElement(xml);
    -
    +      NodeList children = e.getElementsByTagName("core");
    --- End diff --
    
    Yes, that seems better than my solution. I wanted to use the same process 
while reloading conf. as parsing conf. when starting broker 
(https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/FileDeploymentManager.java#L85).
 


---

Reply via email to