[GitHub] activemq-artemis pull request #1722: (WIP DO NOT MERGE) ARTEMIS-1545 Support...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1722#discussion_r157484746
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/Packet.java
 ---
    @@ -42,6 +42,21 @@ default int expectedEncodeSize() {
           return INITIAL_PACKET_SIZE;
        }
     
    +   default boolean isRequiresResponse() {
    --- End diff --
    
    good point, ill move to PacketImpl the default behaviour.


---