Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1736#discussion_r158307133
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
 ---
    @@ -2508,7 +2508,7 @@ private void 
deployQueuesFromListCoreQueueConfiguration(List<CoreQueueConfigurat
                 // if the address::queue doesn't exist then create it
                 try {
                    
createQueue(SimpleString.toSimpleString(config.getAddress()), 
config.getRoutingType(),
    -                           queueName, 
SimpleString.toSimpleString(config.getFilterString()),null,
    +                           queueName, 
SimpleString.toSimpleString(config.getFilterString()), 
SimpleString.toSimpleString(config.getUser()),
    --- End diff --
    
    Its good, we now have an extra test now :) who doesn't like one of those :)
    
    Ok i will merge, cheers.


---

Reply via email to