I like removing it. One concern comes to mind - this really is a non-backward-compatible change, right? Do we bump the major version number, or do we ignore semantic versioning?
I know that can get into a bigger discussion - I'm not trying to open a can of worms. However, I do think we need to be mindful of this concern. Art On Thu, Dec 21, 2017 at 7:21 AM, Christopher Shannon < [email protected]> wrote: > Yeah makes sense to see if anyone has any objections to removing it > completely. I'm ok removing it but not sure if others are still relying on > it (We might even want to ask this question on the users list) > > Here is the original thread about the deprecation discussion: > http://activemq.2283324.n4.nabble.com/DISCUSS-LevelDB- > deprecation-td4719227.html > > As I pointed out in my last post in that thread, we can still keep it > around if there are objections but I suspect it will eventually start to > cause issues if we don't maintain it (such as if we upgrade to JDK 9, or > other dependencies being upgraded like Guava) > > On Thu, Dec 21, 2017 at 8:01 AM, Hadrian Zbarcea <[email protected]> > wrote: > > > Thanks Chris, > > > > I would mention that leveldb will still stay in 5.15.x which will be > > maintained for a significant time, giving users enough time to migrate > back > > to kahadb. > > > > Let's give it a few days and see how much consensus there is in the > > community. > > > > Cheers, > > Hadrian > > > > > > > > On 12/21/2017 07:31 AM, Christopher Shannon wrote: > > > >> +1, it has been deprecated and not maintained for a while so probably > time > >> to be removed. > >> > >> On Wed, Dec 20, 2017 at 10:52 PM, Hadrian Zbarcea <[email protected]> > >> wrote: > >> > >> Hi, > >>> > >>> The activemq-leveldb-store module is already deprecated. Shouldn't we > >>> remove it in 5.16.0? > >>> > >>> Hadrian > >>> > >>> > >> >
